Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up headings #2249

Merged
merged 2 commits into from Jan 15, 2024
Merged

Clean up headings #2249

merged 2 commits into from Jan 15, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Jan 12, 2024 •
edited

Fixes #2248

  • Fix content overlapping
  • Move existed <h2> to <h1>
Before After
image image

@JuliaKirschenheuter
fix(photos): adapt headings and <h1> styles
6294334 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jan 12, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 12, 2024
ShGKme
ShGKme approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine that the main heading now in the navigation, not the main content?

@JuliaKirschenheuter
Copy link
Contributor Author

Is it fine that the main heading now in the navigation, not the main content?

As far i can see heading is outside of the navigation and is inside the <main> element
Screenshot from 2024-01-15 10-17-51

@ShGKme
Copy link
Contributor

ShGKme commented Jan 15, 2024

As far i can see heading is outside of the navigation and is inside the <main> element

Sorry, I was confused by "Navigation" in the component name.

@JuliaKirschenheuter
Copy link
Contributor Author

/compile

@JuliaKirschenheuter
chore(assets): Recompile assets
9753335 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter merged commit 33b71ce into master Jan 15, 2024
23 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/2248-Clean_up_headings branch January 15, 2024 13:23
@JuliaKirschenheuter
Copy link
Contributor Author

/backport 6294334 to stable28

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jan 15, 2024
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 15, 2024
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Jan 15, 2024
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV]: Clean up headings
4 participants
@JuliaKirschenheuter @ShGKme @artonge @Pytal