Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just because an array key doesn't imply the value at that key isn't null. #2279

Merged
merged 1 commit into from Jan 24, 2024
Merged

Just because an array key doesn't imply the value at that key isn't null. #2279

merged 1 commit into from Jan 24, 2024

Conversation

jakkarth
Copy link
Contributor

Fixes #2225.

…ull.

Fixes #2225.

Signed-off-by: JS Moore <js@jsmoore.dev>
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@artonge artonge merged commit 6667dbe into nextcloud:master Jan 24, 2024
29 checks passed
@jakkarth jakkarth deleted the issue/2225 branch January 24, 2024 18:02
@artonge
Copy link
Collaborator

artonge commented Jan 25, 2024

/backport to stable28

Copy link

backportbot bot commented Jan 25, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/2279/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 718f93c066bdcb4ea3783a89fffb1a59199391f5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2279/stable28

Error: Failed to create pull request: Failed to request reviews: Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the nextcloud/photos repository.


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

github-actions bot commented Feb 8, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-request Pending backport by the backport-bot feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OriginalDateTimeMetadataProvider unexpected null value
2 participants