Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Link should work not only for shared members #1153

Closed
martinelkb opened this issue Oct 11, 2020 · 6 comments · Fixed by #1169
Closed

Public Link should work not only for shared members #1153

martinelkb opened this issue Oct 11, 2020 · 6 comments · Fixed by #1169
Milestone

Comments

@martinelkb
Copy link

What is going wrong?

Public Link should work for everyone, not only for shared members

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Öffentlichen Link hinzufügen' (Create a public Link)
  2. Click on 'Link in Zwischenablage kopieren' (Copy to the clipboard)
  3. Send the Link to a another person that has an account, but was not specially added to "Freigaben" (Shares)

Expected behavior
The public Link should open to the shared poll for users that are previously logged (or lead in the first step to a login page).

Public Link Link should work as an invitation to the poll.

Behavior
Logged User gets the Message if following the Link
"No existing polls." : "Keine Umfragen vorhanden.",

Screenshots
poll_bug_issue

Nextcloud/ownCloud version: (see Nextcloud admin page)

Version "19.0.3",

@dartcafe
Copy link
Collaborator

That would break the logic and would cause a lot of developing and testing. We rely on the defined share settings for internal users. Either invite the user directly, share with a group or set the poll to public (Visible to other users).

If a poll is Hidden to other users no one can enter the poll exept users who are invited to the poll (or not logged in users via a public share link).

I see the break in the logic, you raise. But I would see the break in the settings 'hidden poll' and entering it via a public link.

I leave this issue open and put it in the backlog. But I cannot proove, when we are able to go in this.

@dartcafe dartcafe added this to the backlog milestone Oct 12, 2020
@brtptrs
Copy link

brtptrs commented Oct 12, 2020

Many of our users have problems with this behaviour.

Say a user with a NC account receives a public-link invitation to a poll via mail, chat or on a private web page. This is "internal" since one does not want everybody to see the poll.

Example:
At a conference I want to start a poll but don't know who has a NC account, it is a huge effort to split the invitation between people with and without accounts.

  • The user follows the link
  • A dialogue allows the option: "I already have a NC account"
  • The user logs in
  • Now the user gets a "poll does not exist" error.

I'm pretty sure that this used to be different. The behaviour the users expect is the same as elsewhere in NC i.e. with file sharing.

@dartcafe
Copy link
Collaborator

Nice use case. I think, we can achieve this by adding a user to the shares, when he enters the poll via a public share token and the poll is a hidden poll?
Additionally skip invitation mail or the unsent invitation status.

@sress
Copy link

sress commented Oct 16, 2020

@dartcafe
Thanks!
We already had some users wondering why they got the poll does not exist error.

A fix would be much appreciated.

@dartcafe
Copy link
Collaborator

As I am changing the share system internally, this depends on the circles integration, which I plan for version 1.6. Good chance to get this done in this version too.

@dartcafe dartcafe modified the milestones: backlog, next Oct 16, 2020
@martinelkb
Copy link
Author

As I am changing the share system internally, this depends on the circles integration, which I plan for version 1.6. Good chance to get this done in this version too.

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants