Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polls 3.1: Options with quotation marks are not shown translated #1908

Closed
spreeni151 opened this issue Aug 24, 2021 · 12 comments
Closed

Polls 3.1: Options with quotation marks are not shown translated #1908

spreeni151 opened this issue Aug 24, 2021 · 12 comments

Comments

@spreeni151
Copy link

After updating from NC20 to 21 and upgrading polls to 3.1 there are problems with the translations of the app. Some options are shown in English, most others in system's language (German).
I recognized, that all parts that are shown in Englich contain quotation marks like 'Allow "Maybe" vote' . So I thought if there could be a syntax conflict with the translation files of the l10n folder, which also use quotation marks. If it's so we could easyly avoid this by using '-marks instead of "-marks.

Nextcloud 21.0.4
Polls 3.1
PHP 7.4
MariaBD 10.5
Apache Server

in config.php used localize params:

'default_phone_region' => 'DE', 'force_language' => 'de', 'default_language' => 'de', 'default_locale' => 'de_DE',

Regards,
Frank

@dartcafe
Copy link
Collaborator

@Valdnet Do you mind, to check this?

@spreeni151
Copy link
Author

I just found out that this is an issue with the 3.1 version of polls. I compared it with version 3.0, which shows all parts of the text translated correctly. Perhaps this information will help to find the problem.

@Valdnet
Copy link
Contributor

Valdnet commented Aug 25, 2021

In the German (de) translation, not all text strings are translated, therefore some text strings (including those mentioned in issue) in the application may appear in English.

@spreeni151 If you change 'default_language' => 'de' to 'default_language' => 'de_DE' you should get the german translation.

@Valdnet
Copy link
Contributor

Valdnet commented Aug 25, 2021

@rakekniven Twenty text strings are not translated for German in (de) for Polls. Can you check and supplement if not a problem 😉.

@rakekniven
Copy link
Member

Hello all,

the "de" version is the informal version of german. The de_DE version is formal and this this version is translated and checked with care and attention.
The informal version does not get the same attention. There are not enough volunteers to take care of the project on a continuous basis.

@rakekniven
Copy link
Member

Just did a quick search at Transifx. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/forms/317253354?q=reviewed%3Ano

Currently all strings are translated for "de". Maybe this hasn't been the case at the date the last release was done.
So the next release should be fully translated.

@dartcafe
Copy link
Collaborator

This is polls, not forms. ;-)

@rakekniven
Copy link
Member

You are absolutely right.

Current numbers for polls:
grafik

@Valdnet
Copy link
Contributor

Valdnet commented Aug 25, 2021

@rakekniven Thanks for checking and explaining 😉.

the "de" version is the informal version of german. The de_DE version is formal and this this version is translated and checked with care and attention.

@spreeni151 The only thing left for you to do is change the language to 'default_language' => 'de_DE'. This will be the best solution for you as there may also be incomplete translations in other applications.

@dartcafe
Copy link
Collaborator

dartcafe commented Aug 25, 2021

Translation for de and DE_de completed and reviewed.

@spreeni151
Copy link
Author

Thank you for your answers, you all do a great job! :-)
I changed 'default_language' to de_DE and the 'force_language' parameter as well. Now Nextcloud is talking a bit different to me, a bit too polite ;-) but polls' translations are shown correct now. It's a bit funny that the 3.0 version could handle the 'de' language version better, that led me on the wrong track.
So, thank you!

@cloud2018
Copy link

Now Nextcloud is talking a bit different to me, a bit too polite ;-)

@spreeni151
Wenn Dir die Du-Variante besser gefällt und Du etwas dazubeitragen willst, kannst auch Du mit (einem Konto) bei Transifex bei der Du-Variante (de) Strings übersetzen: https://www.transifex.com/nextcloud/nextcloud/translate/#de
Infos hierzu stehen unter https://help.nextcloud.com/t/ubersetzungswissen-gultig-fur-das-komplette-nextcloud-projekt-wiki/59850
Je mehr sich beteiligen, desto weniger Strings bleiben unübersetzt und desto mehr Anwender können ihre bevorzugte Sprachvariante wählen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants