-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete a poll completly #801
Comments
I waited for that issue. :-) Comes together with deleting orphaned objects #267. |
@v1r0x Entry issue for you? |
More like a re-entry 😉 |
Votes, options, comments, etc. could be deleted then via a cron job, which regulary deletes all orphaned entries. See #267 |
This should be simply possible with the database using foreign keys and on delete constraints. I'll look into it and how it can be done in nc :) |
@dartcafe I added the logic to delete a poll completely. I'm not sure about the correct term for this action. I'm using One minor thing I couldn't fix (thanks to the horribly bad documentation of the nc apis...) is a route change after the currently selected poll gets deleted. Thus the poll is still selected. Instead it should route to I also added a migration to delete rows in all other DELETE
FROM oc_polls_whatever
WHERE poll_id NOT IN (<IDs of currently existing polls>) should fix that. I have to look into the doctrine documentation on how to run this raw query. You can both @Dennis1993 and @dartcafe test this feature using the |
@v1r0x First: Poll deletion works for me.
You could push the route via
Migration throws MySQL 5.7.28-nmm1-log Since I ran in some trouble because of differences in the db systems, I try to avoid native db functions or capabilities and try to solve these problems inside the php code. My idea was to simply create a tidy background job which deletes orphaned entries. In the end it could do some other tidy too. |
Hmm...I think I like permanently from OP :) are you ok with that?
From some quick googleing I think you already have orphaned entries and thus the constraint can not be added. So deleteing any orphans before the migration should fix that. I'll try to fix that tomorrow |
No preference here. I am OK with that.
Yes, good point against that.
Without checking that, I have for sure. I'll keep them, so I can test this on my dev instance. And BTW: Maybe you could release 1.3 from the master branch? 😁 |
I only added the strings to the js code |
Correct. As soon, as the files with new strings are merged to master, the nighly transifex bot tranferres them to transifex. Translations will arrive the next days, depending on the language support in the transifex teams. |
permanently In English you wouldn't use |
Since this issue has been fixed a long time ago, shouldn't I find a delete delete option in each poll's three dot menu? Unfortunately, I don't. :-( All I've found is an occ command in the README. Polls 7.0.2, Nextcloud 28.0.4 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
It is not possible to delete a poll permanently.
If we do some polls the list will be long :D
The text was updated successfully, but these errors were encountered: