Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS build break #74

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Fix JS build break #74

merged 2 commits into from
Mar 21, 2019

Conversation

ChristophWurst
Copy link
Member

The vue and vue-template-compiler have to be used in the identical version, otherwise the build fails. This is the case on master right now. This PR adds Vue as dependency (it was just a subdependency before) and updates to the latest vue-template-compiler. This makes the app build again and also ensures that Dependabot updates keep the versions in sync.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Mar 21, 2019
@ChristophWurst ChristophWurst self-assigned this Mar 21, 2019
@ChristophWurst ChristophWurst added this to IN PROGRESS (max 3 PRs) in Christoph's Tasks via automation Mar 21, 2019
@MorrisJobke MorrisJobke mentioned this pull request Mar 21, 2019
9 tasks
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Christoph's Tasks automation moved this from IN PROGRESS (max 3 PRs) to TO INTEGRATE Mar 21, 2019
@rullzer rullzer merged commit be5d08d into master Mar 21, 2019
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Mar 21, 2019
@rullzer rullzer deleted the fix/js-build-break branch March 21, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants