Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed checkbox 'checked' property #66

Merged
merged 1 commit into from Mar 24, 2021
Merged

fixed checkbox 'checked' property #66

merged 1 commit into from Mar 24, 2021

Conversation

adripo
Copy link
Contributor

@adripo adripo commented Mar 22, 2021

fixed checkbox change retrieval with correct method .prop
fix #65

https://api.jquery.com/attr/

As of jQuery 1.6, the .attr() method returns undefined for attributes that have not been set. To retrieve and change DOM properties such as the checked, selected, or disabled state of form elements, use the .prop() method.

@adripo
fixed checkbox 'checked' property
daaba70 
fixed checkbox change retrieval with correct method .prop
fix nextcloud#65

Signed-off-by: adripo <26493496+adripo@users.noreply.github.com>
@nickvergessen nickvergessen merged commit 9fce4e7 into nextcloud:master Mar 24, 2021
@nickvergessen
Copy link
Member

Thanks a lot for the analysis and the PR!

@nickvergessen
Copy link
Member

/backport to stable21

@nickvergessen
Copy link
Member

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 24, 2021
Merged
@nickvergessen
Copy link
Member

/backport to stable19

This was referenced Mar 24, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
backport-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email notification not working
2 participants
@adripo @nickvergessen