Zero safety #398
Merged
Zero safety #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
julien-nc
approved these changes
Oct 19, 2022
marcelklehr
commented
Oct 20, 2022
| $distance = new Euclidean(); | ||
| $distanceValue = $distance->compute($centroid, $this->faceDetection->getVector()); | ||
| // Set threshold to avoid recreating the same mistake | ||
| $this->faceDetection->setThreshold($distanceValue); |
There was a problem hiding this comment.
Here we only want to calculate and set a threshold if there's more than the one face in the cluster, otherwise we do a useless calculation.
marcelklehr
commented
Oct 20, 2022
| @@ -107,7 +107,8 @@ public function calculateClusters(string $userId) { | |||
| /** @var FaceDetection $detection */ | |||
| $detection = $item[0]; | |||
| $distance = new Euclidean(); | |||
| if ($detection->getThreshold() > 0.0) { | |||
| // If threshold is larger than 0 and $clusterCentroid is not the null vector | |||
| if ($detection->getThreshold() > 0.0 && count(array_filter($clusterCentroid, fn($el) => $el !== 0.0)) > 0) { | |||
There was a problem hiding this comment.
If the centroid could not be calculated, because there were zero detections in the cluster (see below), the centroid will be the null vector (count(array_filter($clusterCentroid, fn($el) => $el !== 0.0)) > 0 checks if it is not the null vector). Then we don't want to apply the threshold either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #397