Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(dashboard): implement widget item api v2 #641

Merged
merged 1 commit into from Sep 5, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 17, 2023

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny marked this pull request as ready for review September 5, 2023 11:06
@st3iny
Copy link
Member Author

st3iny commented Sep 5, 2023

/backport to stable27

@st3iny st3iny merged commit 1385232 into master Sep 5, 2023
18 checks passed
@st3iny st3iny deleted the perf/dashboard/item-api-v2 branch September 5, 2023 11:54
@backportbot-nextcloud

This comment was marked as resolved.

@ChristophWurst
Copy link
Member

I've noticed a small feature regression. The old Vue widget allowed me to click on the preview of an image and open the file in the Viewer. The new API widget only offers a link to the file. Could that be a problem?

@ChristophWurst
Copy link
Member

The feature was added with 800310a. So cc @juliushaertl

@juliushaertl
Copy link
Member

Would be nice to have this back to avoid full page loads whenever possible, but probably less critical with 28 where the files app becomes a lot faster in loading with vue.

@ChristophWurst
Copy link
Member

@jancborchardt @marcoambrosini @nimishavijay is it sufficient to have a quick files app and navigating to the recommended file or shall we revive the less performant widget with the direct viewer integration?

@jancborchardt
Copy link
Member

Direct viewer integration is a much much nicer experience. (Otherwise the dashboard is always only a clunky jumping-off point instead of making it seamless.) Can we do that and get it more performant?

@ChristophWurst
Copy link
Member

We can't. The new, performant widgets only work with standard lists. For the Viewer integration we need our own script.

@ChristophWurst
Copy link
Member

Let's revert this PR @st3iny

In the future we might be able to advance the widget APIs again for an option to open Viewer for the thumbnail of an entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants