Skip to content

Commit

Permalink
Create proper Settings Section
Browse files Browse the repository at this point in the history
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
  • Loading branch information
jotoeri committed Feb 3, 2021
1 parent b903ca2 commit 7343fee
Show file tree
Hide file tree
Showing 3 changed files with 75 additions and 2 deletions.
1 change: 1 addition & 0 deletions appinfo/info.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,6 @@ This app allows users to register a new account.
</dependencies>
<settings>
<admin>OCA\Registration\Settings\RegistrationSettings</admin>
<admin-section>OCA\Registration\Settings\RegistrationSettingsSection</admin-section>
</settings>
</info>
3 changes: 1 addition & 2 deletions lib/Settings/RegistrationSettings.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public function __construct(string $appName,
$this->appName = $appName;
$this->config = $config;
$this->groupManager = $groupManager;
$this->appName = $appName;
}

public function getForm(): TemplateResponse {
Expand Down Expand Up @@ -86,7 +85,7 @@ public function getForm(): TemplateResponse {
}

public function getSection(): string {
return 'additional';
return 'registration';
}

public function getPriority(): int {
Expand Down
73 changes: 73 additions & 0 deletions lib/Settings/RegistrationSettingsSection.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
<?php
/**
* @copyright Copyright (c) 2021 Jonas Rittershofer <jotoeri@users.noreply.github.com>
*
* @author Jonas Rittershofer <jotoeri@users.noreply.github.com>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

namespace OCA\Registration\Settings;

use OCP\IL10N;
use OCP\IURLGenerator;
use OCP\Settings\IIconSection;

class RegistrationSettingsSection implements IIconSection {
/** @var IL10N */
private $l10n;

/** @var IURLGenerator */
private $urlGenerator;

public function __construct(IL10N $l10n, IURLGenerator $urlGenerator) {
$this->l10n = $l10n;
$this->urlGenerator = $urlGenerator;
}

/**
* Section ID to be set in Settings
* @return string
*/
public function getID(): string {
return 'registration';
}

/**
* Section Name to be displayed
* @return string
*/
public function getName(): string {
return $this->l10n->t('Registration');
}

/**
* Return Priority of section 0-100
* @return int
*/
public function getPriority(): int {
return 80;
}

/**
* Pass the relative path to the icon
* @return string
*/
public function getIcon(): string {
return $this->urlGenerator->imagePath('registration', 'app.svg');
}
}

0 comments on commit 7343fee

Please sign in to comment.