Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Open in local editor" button icon cannot display (icon url has redundant port number) #2572

Closed
mayswind opened this issue Oct 23, 2022 · 0 comments · Fixed by #2573
Closed

"Open in local editor" button icon cannot display (icon url has redundant port number) #2572

mayswind opened this issue Oct 23, 2022 · 0 comments · Fixed by #2573
Assignees
@Raudius
Labels
0. Needs triage bug Something isn't working

Comments

@mayswind
Copy link
Contributor

mayswind commented Oct 23, 2022 •
edited
Loading

Describe the bug
The Icon url of "Open in local editor" button is invalid when nextcloud deploys on an non 80/443 port webserver. The icon url has redundant a port number (see the below screenshot). I check the related code, and find the port number is inserted twice in the pr #2442 (https://github.com/nextcloud/richdocuments/pull/2442/files#diff-ce81efd19e432a3cd0658d52cccd7c8fbd4b01f4ada9b174f949578fe9af8578R89).

To Reproduce
Steps to reproduce the behavior:

  1. Deploy nextcloud on a webserver with a non 80/443 http port
  2. Click any document and use richdocument open it
  3. See error

Expected behavior
The Icon of "Open in local editor" button should display

Screenshots
image

Client details:

  • OS: Windows
  • Browser: Edge
  • Version: 106.0.1370.52
  • Device: Desktop

Server details

Operating system: Debian 11

Web server: Nginx + PHP-FPM

Database: MariaDB

PHP version: 8.1.11

Nextcloud version: 25.0.0

Version of the richdocuments app 7.0.0

Version of Collabora Online 22.05.7.2.1
@mayswind mayswind mentioned this issue Oct 23, 2022
Merged
3 tasks
@Raudius Raudius self-assigned this Oct 23, 2022
@Raudius Raudius added bug Something isn't working 0. Needs triage labels Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raudius Raudius

Labels
0. Needs triage bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix redundant port number in url mayswind/richdocuments
2 participants
@mayswind @Raudius