Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redundant port number in url #2573

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Fix redundant port number in url #2573

merged 1 commit into from
Oct 24, 2022

Conversation

mayswind
Copy link
Contributor

@mayswind mayswind commented Oct 23, 2022 •
edited

Summary

Fix redundant port number in the url. window.location.host already includes the port, but the code appends another port after this. see https://developer.mozilla.org/en-US/docs/Web/API/Location/host .

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@mayswind
fix redundant port number in url
b3c5ead 
Signed-off-by: MaysWind <i@mayswind.net>
@juliushaertl juliushaertl added bug Something isn't working 4. to release Ready to release, can be waiting for the tests to finish labels Oct 24, 2022
@juliushaertl juliushaertl merged commit c1e1ba1 into nextcloud:master Oct 24, 2022
@juliushaertl
Copy link
Member

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees

@Raudius Raudius

Labels
4. to release Ready to release, can be waiting for the tests to finish bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Open in local editor" button icon cannot display (icon url has redundant port number)
3 participants
@mayswind @juliushaertl @Raudius