Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup public_wopi_url and handle internal hostnames #3313

Closed
juliushaertl opened this issue Nov 22, 2023 · 0 comments · Fixed by #3315
Closed

Cleanup public_wopi_url and handle internal hostnames #3313

juliushaertl opened this issue Nov 22, 2023 · 0 comments · Fixed by #3315
Assignees
Labels
1. to develop Waiting for a developer enhancement New feature or request

Comments

@juliushaertl
Copy link
Member

public_wopi_url is not very useful, we should get rid of that and instead always inherit the url from the discovery response. However when collabora connects back to Nextcloud we always pass the URL that a user used to access Nextcloud which in some cases might not be suitable and an internal url should rather be used.

Discovery endpoint returns either the requesting hostname or if configured server_name from coolwsd.xml

Requests and used urls

  • nextcloud -> collabora (wopi_url setting) (internal)
  • browser -> collabora (derived from /hosting/discovery, request above or server name) (external)
  • collabora -> nextcloud (derived from url in the browser) (ideal internal, currently external)
    • public_wopi_url was introduced to set csp for deriving from request
    • if exposing internal url we can have a override config value
      • if not this gets more tricky and we need this to work on the collabora server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Waiting for a developer enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant