Fix bug #1054 #1055
Merged
Fix bug #1054 #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| } | ||
| /** |
There was a problem hiding this comment.
Please use tabs instead of spaces
|
|
||
| $table = $schema->getTable('richdocuments_wopi'); | ||
|
|
||
| if(!$table->hasColumn('template_id')) { |
There was a problem hiding this comment.
Could you create a new migration for all of those checks, so we make sure they are also executed if someone has already updated but not encountered the issue yet?
|
Thanks a lot for your pull request. I left some review comments in the code. Please also make sure to add a signoff message to your commit. The other CI failure seems like a temporary error https://drone.nextcloud.com/nextcloud/richdocuments/1007/4/3 |
|
Is this ready? Good enough to be merged? |
|
Looks good to me now, @SamKer mind to add a signoff message to your commits as well? See https://probot.github.io/apps/dco/ for details |
added 3 commits
July 7, 2020 14:20
Signed-off-by: KERIOU Samir <samir.keriou@gendarmerie.interieur.gouv.fr>
Signed-off-by: KERIOU Samir <samir.keriou@gendarmerie.interieur.gouv.fr>
Signed-off-by: KERIOU Samir <samir.keriou@gendarmerie.interieur.gouv.fr>
juliushaertl
approved these changes
Sep 3, 2020
|
Thanks a lot for taking care of this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding test if column exist for all missing columns when update richdocument 3.2.4 to 3.7.x