Passing some UI Defaults to loleaflet frame #1211
Conversation
These ui defaults determine some widget states at the start of the document which is hidden or shown Some of them such as Ruler Statusbar and Sidebar can be hidden at start with this patch. If not set, collabora online will assume they are true Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
|
@juliushaertl Can you please review these patches? Thank you |
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
gary-kim
added
3. to review
| } | ||
| var str = '' | ||
| for (var cssVarKey in cssVarMap) { | ||
| var cStyle = window.parent.getComputedStyle(document.documentElement).getPropertyValue(cssVarKey) |
There was a problem hiding this comment.
| var cStyle = window.parent.getComputedStyle(document.documentElement).getPropertyValue(cssVarKey) | |
| var cStyle = window.getComputedStyle(document.documentElement).getPropertyValue(cssVarKey) |
There was a problem hiding this comment.
The CSS variables are also properly loaded inside of the document frame.
| var cStyle = window.parent.getComputedStyle(document.documentElement).getPropertyValue(cssVarKey) | ||
| if (!cStyle) { | ||
| // try suffix -dark instead | ||
| cStyle = window.parent.getComputedStyle(document.documentElement).getPropertyValue(cssVarKey + '-dark') |
There was a problem hiding this comment.
| cStyle = window.parent.getComputedStyle(document.documentElement).getPropertyValue(cssVarKey + '-dark') | |
| cStyle = window.getComputedStyle(document.documentElement).getPropertyValue(cssVarKey + '-dark') |
There was a problem hiding this comment.
Thank you for the reply. Initially it was like this but later we discovered that it does not work on Firefox without parent. The CSS variables become empty string. The only solution I found was using window.parent.
There was a problem hiding this comment.
Indeed seems to be a firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1471231
Then let's get this in as it is and maybe see if we can work around that by not using display: none; but opacity of 0 until the frame is loaded.
Co-authored-by: Julius Härtl <jus@bitgrid.net>
These ui defaults determine some widget states
at the start of the document which is hidden or shown
Some of them such as Ruler Statusbar and Sidebar can be
hidden at start with this patch. If not set, collabora
online will assume they are true
Signed-off-by: Mert Tumer mert.tumer@collabora.com
Summary
TODO
Checklist