Increase timeout if proxy is starting #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
eszkadev
force-pushed
the
increase-proxy-timeout
branch
from
d07e1fa
to
5a83a1b
Compare
| @@ -77,6 +77,35 @@ public function fetchFromRemote() { | |||
| $options['verify'] = false; | |||
| } | |||
|
|
|||
| // first load with proxy can take some time - increase timeout in that case | |||
| $usesProxy = false; | |||
There was a problem hiding this comment.
Would probably be nice to move this into a dedicated function so the general flow is a bit more readable and we might be able to reuse this in case we need it for any other request that might run into the default timeout.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
juliushaertl
approved these changes
Nov 24, 2020
juliushaertl
added
4. to release
juliushaertl
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Szymon Kłos szymon.klos@collabora.com
Summary
TODO
Checklist