Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add avatar to UserExtraInfo #130

Merged
merged 2 commits into from Oct 19, 2017
Merged

Add avatar to UserExtraInfo #130

merged 2 commits into from Oct 19, 2017

Conversation

LukasReschke
Copy link
Member

Will require master of Nextcloud (aka 13) and nextcloud/server#6813 merged.

Signed-off-by: Lukas Reschke lukas@statuscode.ch

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke
Copy link
Member Author

screen shot 2017-10-11 at 15 26 45

screen shot 2017-10-11 at 15 28 50

@timar
Copy link
Member

timar commented Oct 12, 2017

Thanks for this @LukasReschke ! Does that mean that we need to make a branch for nc12 before we merge this patch?

@LukasReschke
Copy link
Member Author

In addition, I'll work on the following change in the server to always return a proper avatar: nextcloud/server#5750

@LukasReschke
Copy link
Member Author

Thanks for this @LukasReschke ! Does that mean that we need to make a branch for nc12 before we merge this patch?

Sadly, this feature will only properly work with Nextcloud 13 due to nextcloud/server#5750 and nextcloud/server#6813 being required.

I can add a if block around it to include the user extra info only if we're on >= 13. That should work around the problems here.

Objections? :-)

@timar
Copy link
Member

timar commented Oct 12, 2017

`

I can add a if block around it to include the user extra info only if we're on >= 13. That should work around the problems here.

That would be great, thanks.

@rullzer
Copy link
Member

rullzer commented Oct 15, 2017

nextcloud/server#6813 is merged

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke
Copy link
Member Author

@timar Done.

@timar timar merged commit 12bb8c0 into master Oct 19, 2017
@LukasReschke LukasReschke deleted the add-avatar-to-userextrainfo branch October 19, 2017 14:46
rotdrop pushed a commit to rotdrop/nextcloud-richdocuments that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants