Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use libxml_disable_entity_loader on PHP 8 or later #1502

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Do not use libxml_disable_entity_loader on PHP 8 or later #1502

merged 1 commit into from
Apr 23, 2021

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Apr 22, 2021 •
edited
Loading

Avoid deprecation logs on PHP 8

https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation

In PHP 8.0 and later, PHP uses libxml versions from 2.9.0, which disabled XXE by default. libxml_disable_entity_loader() is now deprecated.

@juliushaertl
Do not use libxml_disable_entity_loader on PHP 8 or later
d012b51 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added 3. to review Ready to be reviewed bug Something isn't working labels Apr 23, 2021
@juliushaertl
Copy link
Member Author

oci failure seems to be an issue with the github action that installs the php module, unrelated to this PR.

@juliushaertl juliushaertl merged commit 934fce9 into master Apr 23, 2021
@juliushaertl juliushaertl deleted the techdebt/php8-libxml_disable_entity_loader branch April 23, 2021 11:35
@juliushaertl juliushaertl mentioned this pull request Apr 23, 2021
Closed
@KimHEF
Copy link

KimHEF commented Aug 23, 2021 •
edited
Loading

Hey Thanks for your Solution.
I am not very familiar with PHP.... so i have to deactivate this Module, right?
Could you explain how?

Kind Regards.

@juliushaertl juliushaertl mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juliushaertl @KimHEF @ChristophWurst