Revert "Do not hide speadsheet statusbar by default" #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete-merged-branch
bot
deleted the
revert-2053-bugfix/spreadsheet-statusbar
branch
4 tasks
pedropintosilva
added a commit
that referenced
this pull request
Nov 27, 2023
Status bar is crucial for productivity tool (specially when it comes to office suites and in specific spreadsheets). Context, this is a regression from: - #2059 - fabed16 Even if, and as noted in #2053 (comment), the status bar was still being hidden for safari I think it's best to don't break the spreadsheet experience for every browser. On top of that I think the richdocuments frame suffer some changes and that safari issue might not be present anymore. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
Status bar is crucial for productivity tool (specially when it comes to office suites and in specific spreadsheets). Context, this is a regression from: - #2059 - fabed16 Even if, and as noted in #2053 (comment), the status bar was still being hidden for safari I think it's best to don't break the spreadsheet experience for every browser. On top of that I think the richdocuments frame suffer some changes and that safari issue might not be present anymore. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
Status bar is crucial for productivity tool (specially when it comes to office suites and in specific spreadsheets). Context, this is a regression from: - #2059 - fabed16 Even if, and as noted in #2053 (comment), the status bar was still being hidden for safari I think it's best to don't break the spreadsheet experience for every browser. On top of that I think the richdocuments frame suffer some changes and that safari issue might not be present anymore. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
rotdrop
pushed a commit
to rotdrop/nextcloud-richdocuments
that referenced
this pull request
Dec 8, 2023
Status bar is crucial for productivity tool (specially when it comes to office suites and in specific spreadsheets). Context, this is a regression from: - nextcloud#2059 - fabed16 Even if, and as noted in nextcloud#2053 (comment), the status bar was still being hidden for safari I think it's best to don't break the spreadsheet experience for every browser. On top of that I think the richdocuments frame suffer some changes and that safari issue might not be present anymore. Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2053 as per discussion in the PR