-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option to use new grouped saveas #2551
Conversation
COOL can now provide extensions for different file types such as odt to docx etc. without needing to type it manually. Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
@juliushaertl the Online counterpart already merged : CollaboraOnline/online#5252 and it seems this richdocuments commits were forgotten (cc: @merttumer @timar @eszkadev ) Note: I have tested it locally, it works |
Thanks for that @pedropintosilva ❤️ |
/backport to stable25 |
/backport to stable24 |
Actually when I tested (it was in some not so recent version of richdocument) I have tried to test it again via 25stable and I'm not able.. So I have pulled latest NC docker, removed richdocuments, git clone , checkout 25stable (just to be sure the commit is there) and I'm not able to see it... I'm not sure if anything changed. However, I'm able to see it if
And then it works for any document after this^ |
@juliushaertl maybe because |
and then after #2551 (comment) I'm not able to reproduce the bug again, even with a newly created user and new document |
I just remove richdocuments, pulled again ... and it works now... rm -rf richdocuments/
git clone https://github.com/nextcloud/richdocuments.git
cd richdocuments/
git checkout 25stable
npm ci
npm run dev 🤷♂️ I don't understand |
Aha! @eszkadev alluded tot he fact that maybe it was simply cache that NC caching for some properties and it is possible that it was updated at some point and started to work, but before it was using old values |
COOL can now provide extensions for different
file types such as odt to docx etc. without needing to type it manually.
Signed-off-by: Mert Tumer mert.tumer@collabora.com
Summary
TODO
Checklist