Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to use new grouped saveas #2551

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

pedropintosilva
Copy link
Contributor

COOL can now provide extensions for different
file types such as odt to docx etc. without needing to type it manually.

Signed-off-by: Mert Tumer mert.tumer@collabora.com

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

COOL can now provide extensions for different
file types such as odt to docx etc. without needing
to type it manually.

Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
@pedropintosilva
Copy link
Contributor Author

pedropintosilva commented Oct 20, 2022

@juliushaertl the Online counterpart already merged : CollaboraOnline/online#5252 and it seems this richdocuments commits were forgotten (cc: @merttumer @timar @eszkadev )

Note: I have tested it locally, it works

@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Oct 21, 2022
@juliushaertl
Copy link
Member

Thanks for that @pedropintosilva ❤️

@juliushaertl juliushaertl merged commit e4f0f07 into master Oct 21, 2022
@juliushaertl juliushaertl deleted the private/mert/new-group-saveas-parameter branch October 21, 2022 07:03
@juliushaertl
Copy link
Member

/backport to stable25

@juliushaertl
Copy link
Member

/backport to stable24

@pedropintosilva
Copy link
Contributor Author

pedropintosilva commented Oct 24, 2022

Actually when I tested (it was in some not so recent version of richdocument) I have tried to test it again via 25stable and I'm not able..

So I have pulled latest NC docker, removed richdocuments, git clone , checkout 25stable (just to be sure the commit is there) and I'm not able to see it... I'm not sure if anything changed. However, I'm able to see it if

  1. File -> Properties
  2. Set password
  3. Password dialog: type apss
  4. Save
  5. Close
  6. Open the same file
  7. Go to file

image
and in compact mode
image

And then it works for any document after this^

@pedropintosilva
Copy link
Contributor Author

@juliushaertl maybe because saveAsMode is not set initially (?)

@pedropintosilva
Copy link
Contributor Author

and then after #2551 (comment) I'm not able to reproduce the bug again, even with a newly created user and new document

@pedropintosilva
Copy link
Contributor Author

I just remove richdocuments, pulled again ... and it works now...

rm -rf richdocuments/
git clone https://github.com/nextcloud/richdocuments.git
cd richdocuments/
git checkout 25stable
npm ci
npm run dev

🤷‍♂️ I don't understand

@pedropintosilva
Copy link
Contributor Author

Aha! @eszkadev alluded tot he fact that maybe it was simply cache that NC caching for some properties and it is possible that it was updated at some point and started to work, but before it was using old values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants