Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auto_logout): Register auto_logout listeners to prevent auto_logout while editing #2845

Merged
merged 1 commit into from Mar 10, 2023

Conversation

marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Mar 9, 2023

  • Resolves: -
  • Target version: main

Summary

When the collabora frame is visible the core auto_logout mechanism in session-heartbeat.js isn't tickled anymore and logs the user out after session_lifetime even if there has been activity.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@marcelklehr
Copy link
Member Author

/backport to stable25

@marcelklehr
Copy link
Member Author

/backport to stable26

@juliushaertl
Copy link
Member

Makes sense, thanks for that :)

@juliushaertl
Copy link
Member

/rebase

…ut while editing

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@cypress
Copy link

cypress bot commented Mar 10, 2023

Passing run #184 ↗︎

0 24 0 0 Flakiness 0

Details:

fix(auto_logout): Register auto_logout listeners to prevent auto_logout while ed...
Project: Richdocuments Commit: 18945e6f7d
Status: Passed Duration: 02:40 💡
Started: Mar 10, 2023 10:38 AM Ended: Mar 10, 2023 10:41 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants