Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch and skip errors for adjusting the files view when the file is not present in the list #3010

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jun 11, 2023

Summary

When opening a file from the recommended files there is no need to update it in the file list so we can safely ignore the error in this case.

Handling file updates is quite hacky but hopefully gets a better way to handle once the files to vue migration moves on.

… is not present in the list

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Jun 11, 2023
@cypress
Copy link

cypress bot commented Jun 11, 2023

Passing run #376 ↗︎

0 25 0 0 Flakiness 0

Details:

fix: Catch and skip errors for adjusting the files view when the file is not pre...
Project: Richdocuments Commit: efc1a16373
Status: Passed Duration: 02:46 💡
Started: Jun 11, 2023 7:13 PM Ended: Jun 11, 2023 7:16 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@juliushaertl juliushaertl merged commit ce18e9e into main Jun 12, 2023
36 checks passed
@juliushaertl juliushaertl deleted the bugfix/2933 branch June 12, 2023 07:38
@juliushaertl
Copy link
Member Author

/backport to stable27

@juliushaertl
Copy link
Member Author

/backport to stable26

@juliushaertl
Copy link
Member Author

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening a recommended document with Nextcloud Office and closing it leaves the screen blank
2 participants