Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove broken way of updating the encryption access list #3028

Closed
wants to merge 1 commit into from

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jun 20, 2023

Fix server side encryption as we actually access the file in the user scope with the system key these days.

This broke with 27 as there has been some changes to how the file keys are managed in nextcloud/server#37243

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Jun 20, 2023
@cypress
Copy link

cypress bot commented Jun 20, 2023

Passing run #393 ↗︎

0 25 0 0 Flakiness 0

Details:

fix: Remove broken way of updating the encryption access list
Project: Richdocuments Commit: 5bff693585
Status: Passed Duration: 03:12 💡
Started: Jun 20, 2023 6:08 PM Ended: Jun 20, 2023 6:11 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@blizzz
Copy link
Member

blizzz commented Jul 3, 2023

Fix server side encryption as we actually access the file in the user scope with the system key these days.

Was there are an enforced migration towards systems keys?

@juliushaertl
Copy link
Member Author

Need to double check after nextcloud/server#39447 was merged now

@EukalyptusX
Copy link

Ist there a workaround I can implement by myself? It's a serious issue, that you can't even download the files.

@juliushaertl
Copy link
Member Author

Closing as during my testing I could no longer reproduce this and nextcloud/server#39447 fixes the issue for me.

If this is still an issue for anyone passing by please continue reading at #2996 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot open uploaded docx file when using object storage and encryption
3 participants