Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Wopi): Mark sensitive parameter as such #3042

Merged
merged 1 commit into from Jul 17, 2023

Conversation

nickvergessen
Copy link
Member

Ref nextcloud/server#39040
This is only effective in PHP 8.2+ but it's the better and our future approach so doing both in parallel

@nickvergessen nickvergessen added bug Something isn't working 3. to review Ready to be reviewed labels Jun 28, 2023
@nickvergessen nickvergessen self-assigned this Jun 28, 2023
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also register via IRegistrationContext::registerSensitiveMethods() for PHP < 8.2.

@nickvergessen
Copy link
Member Author

Hmm so that means nextcloud/server#39040 is actually not needed anymore?

@cypress
Copy link

cypress bot commented Jun 29, 2023

Passing run #468 ↗︎

0 25 0 0 Flakiness 0

Details:

fix(Wopi): Mark sensitive parameter as such
Project: Richdocuments Commit: 6f3f8b81bd
Status: Passed Duration: 02:54 💡
Started: Jul 17, 2023 6:38 PM Ended: Jul 17, 2023 6:41 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@blizzz
Copy link
Member

blizzz commented Jun 29, 2023

Hmm so that means nextcloud/server#39040 is actually not needed anymore?

aye

Signed-off-by: Joas Schilling <coding@schilljs.com>
@juliushaertl juliushaertl force-pushed the bugfix/noid/mark-sensitive-parameter-as-such branch from 3161306 to 6f3f8b8 Compare July 17, 2023 17:58
@juliushaertl juliushaertl merged commit 64dda2e into main Jul 17, 2023
42 checks passed
@juliushaertl juliushaertl deleted the bugfix/noid/mark-sensitive-parameter-as-such branch July 17, 2023 18:56
@juliushaertl
Copy link
Member

/backport to stable27

@juliushaertl
Copy link
Member

/backport to stable26

@juliushaertl
Copy link
Member

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants