Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] Version support and iframe refactoring #3172

Merged
merged 12 commits into from Sep 13, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Sep 8, 2023

Backport of #3152

@cypress
Copy link

cypress bot commented Sep 8, 2023

23 failed tests on run #613 ↗︎

23 2 0 6 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

[stable27] Version support and iframe refactoring
Project: Richdocuments Commit: 2f5e3dd58a
Status: Failed Duration: 17:35 💡
Started: Sep 12, 2023 8:30 AM Ended: Sep 12, 2023 8:47 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl force-pushed the backport/3152/stable27 branch 2 times, most recently from 59321ac to 94b6d4e Compare September 9, 2023 07:39
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR added @nextcloud/paths to package.json. Don't know if this went missing here or whether it's unneeded 🤔

@juliushaertl
Copy link
Member Author

Ouh, seem i pushed that to the branch directly by accident 6a867be 🙈

@mejo-
Copy link
Member

mejo- commented Sep 13, 2023

Cypress failures look unrelated, but maybe you can take another look @juliushaertl? I just triggered a re-run.

@juliushaertl juliushaertl merged commit 471dd22 into stable27 Sep 13, 2023
45 of 47 checks passed
@juliushaertl juliushaertl deleted the backport/3152/stable27 branch September 13, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants