New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow current user lock #3206
Allow current user lock #3206
Conversation
15 failed tests on run #669 鈫楋笌
Details:
Review all test suite changes for PR #3206 鈫楋笌 |
lib/Controller/WopiController.php
Outdated
|
||
// This is a quick custom patch to allow richdocuments to accept lock from current user | ||
/** @var OCP\IUserSession $userSession */ | ||
$userSession = \OC::$server->get(\OCP\IUserSession::class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a user session on those requests, we probably should just check against $wopi->getEditorUid()
. However this would then still allow conflicts if the file gets locked by the desktop client and the same user opens it in Collabora.
@ArtificialOwl Can you provide some more backgorund which case this change should cover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can reproduce the issue:
userA
lock a shared file,userA
open the freshly locked file with richdocument,- the app will not open the said document
|
6652f3c
to
479037c
Compare
Pushed a few adjustments |
a26d592
to
1df469a
Compare
Tested 鉁旓笍 |
1df469a
to
19e0719
Compare
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
19e0719
to
0a5afd4
Compare
/backport to stable27 |
/backport to stable26 |
/backport to stable25 |
No description provided.