Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update file metadata after save #3230

Merged
merged 4 commits into from Oct 19, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Oct 16, 2023

Track the state of the document modification status through the incoming post messages to make sure that we only update the mtime displayed in the file list if the file was actually changed.

Also introduce handling for the new F2V file metadata and emit events on save.

Manual backport is in #3231

@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Oct 16, 2023
@juliushaertl juliushaertl force-pushed the bugfix/noid/vue-update-timestamp branch from 73a1b8b to 3a6fc4c Compare October 17, 2023 08:24
@cypress
Copy link

cypress bot commented Oct 17, 2023

15 failed tests on run #667 ↗︎

15 7 5 5 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix: Update file metadata after save
Project: Richdocuments Commit: 3a6fc4c405
Status: Failed Duration: 12:26 💡
Started: Oct 17, 2023 8:27 AM Ended: Oct 17, 2023 8:39 AM

Review all test suite changes for PR #3230 ↗︎

@juliushaertl
Copy link
Member Author

CI failures look related to broken viewer - pushing nextcloud/viewer#2006

@juliushaertl juliushaertl force-pushed the bugfix/noid/vue-update-timestamp branch from 3a6fc4c to 6bdb647 Compare October 17, 2023 10:28
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Did not test it though.

src/view/FilesAppIntegration.js Outdated Show resolved Hide resolved
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl force-pushed the bugfix/noid/vue-update-timestamp branch from 6bdb647 to 6e9ab48 Compare October 18, 2023 15:28
@juliushaertl juliushaertl merged commit 3c1a4b4 into main Oct 19, 2023
32 of 36 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/vue-update-timestamp branch October 19, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants