Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly update files app state when using saveAs #3277

Merged
merged 1 commit into from Nov 7, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Nov 6, 2023

When using saveAs the document in use changes to a new one so we need to replace the files route in the background to properly handle a reload of the browser or copying the URL.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl changed the title fix: Properly update files app state when renaming/saveAs fix: Properly update files app state when using saveAs Nov 6, 2023
@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Nov 6, 2023
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me 👍

@juliushaertl juliushaertl merged commit a85616c into main Nov 7, 2023
45 checks passed
@juliushaertl juliushaertl deleted the bugfix/main/saveas-update branch November 7, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants