Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fonts improvement #3304

Merged
merged 2 commits into from Dec 9, 2023
Merged

Feature/fonts improvement #3304

merged 2 commits into from Dec 9, 2023

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Nov 17, 2023 •
edited

Summary

  • Add repair step to install default fonts on installation
  • Add command richdocuments:install-fonts to install default fonts

TODO

  • Font files get shipped as part of richdocuments in an extra assets/fonts/ directory
  • New fonts shall be copied from the assets/fonts folder
  • Add a repair job to add new fonts once to the installation
  • Add an occ command richdocuments:install-fonts to install shipped fonts again if manually removed as the admin
  • Add cypress test that ensures the fonts are listed in the admin settings

@luka-nextcloud luka-nextcloud self-assigned this Nov 17, 2023
@luka-nextcloud luka-nextcloud mentioned this pull request Nov 17, 2023
Closed
13 tasks
@luka-nextcloud luka-nextcloud added the 3. to review Ready to be reviewed label Nov 17, 2023
@kesselb
Copy link
Contributor

kesselb commented Nov 17, 2023

Tip: If composer dump-autoload does not update the autoloader then cd composer. I just ran into the same failing workflow today and was super confused by it 🙈

juliushaertl
juliushaertl reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested yet, but looks good. Only a few minor comments inline.

@juliushaertl juliushaertl added the enhancement New feature or request label Nov 20, 2023
@juliushaertl
Copy link
Member

@luka-nextcloud Please make sure to provide some context like a short pr description and the link to the issue

@juliushaertl
Copy link
Member

Tip: If composer dump-autoload does not update the autoloader then cd composer. I just ran into the same failing workflow today and was super confused by it

Yeah we should probably document that better. I went for a separate composer.json for the autoloader only to avoid dev dependencies getting autoloaded, but not the most straight forward I agree

@luka-nextcloud luka-nextcloud force-pushed the feature/fonts-improvement branch 2 times, most recently from 1c2b935 to f064f26 Compare November 29, 2023 16:57
@luka-nextcloud @juliushaertl
feat: add repair step to install default fonts on installation
1a3411f 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliushaertl
Copy link
Member

Pushed a commit adding the fonts and licenses through a build script.

@juliushaertl juliushaertl force-pushed the feature/fonts-improvement branch 2 times, most recently from 456364d to 36347d6 Compare December 9, 2023 08:16
@juliushaertl
feat: Add script to get fonts on build
93748ff 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 9bdf1b2 into main Dec 9, 2023
58 checks passed
@juliushaertl juliushaertl deleted the feature/fonts-improvement branch December 9, 2023 08:32
@juliushaertl
Copy link
Member

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees

@luka-nextcloud luka-nextcloud

Labels
3. to review Ready to be reviewed enhancement New feature or request feature: fonts
Projects
None yet
Milestone
No milestone
4 participants
@luka-nextcloud @kesselb @juliushaertl @joshtrichards