Fix opening file after rename in COOL #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug which happens after renaming a file inside Collabora Online (using fiels on the headerbar). 1. Open any document 2. Rename it so it will contain spaces 3. Close document 4. Try to open renamed document from the list Result: error, cannot find file Notice that name was encoded so space become %20. If you look at requests - the name of a file become encoded second time in one of them so it failed. eg. file '1 1.odt' after rename does request: http://192.168.0.108/remote.php/dav/files/admin/1%25201.odt In Nextcloud 27 visible name doesn't contain %20 but still doesn't work. Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Passing run #734 ↗︎
Details:
Review all test suite changes for PR #3341 ↗︎ |
|||||||||||||||
juliushaertl
approved these changes
Dec 6, 2023
|
should I prepare PR for stable27 and master too? |
That would be appreciated if it also works there The code paths on master might be different as we rewrote the files app in parts with new frontend code in the server itself. Feel free to also just open an issue then I can have a closer look there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug which happens after renaming a file inside Collabora Online (using fiels on the headerbar).
Notice that name was encoded so space become %20.
If you look at requests - the name of a file become encoded second time in one of them so it failed.
eg. file '1 1.odt' after rename does request:
http://192.168.0.108/remote.php/dav/files/admin/1%25201.odt
In Nextcloud 27 visible name doesn't contain %20 but still doesn't work.