Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid 3px offset on public share links #3369

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Dec 19, 2023

Avoid that the background page is shining through at the bottom of public share links

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Dec 19, 2023
@juliushaertl
Copy link
Member Author

/backport to stable28

@juliushaertl
Copy link
Member Author

/backport to stable27

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliushaertl does this have anything to do with the color accent bar on the top at the compact view? Cause that does not show for the share link in compact view (does show for compact view when logged in).
It correctly does not show for tabbed view regardless of log in status.

@juliushaertl
Copy link
Member Author

@juliushaertl does this have anything to do with the color accent bar on the top at the compact view? Cause that does not show for the share link in compact view (does show for compact view when logged in).

Before this patch the accent bar in compact mode was hidden due to this offset.

Now with this patch the behaviour is the following (which I think is the expected):

  • Compact mode shows accent bar
  • Tabbed mode shows no accent bar

@pedropintosilva
Copy link
Contributor

Thanks @juliushaertl I'm a bit afraid of this. By he looks of it, it seems will affect the component height and position no matter if it's share link or not (unless that is only used in those cases). I also would like to understand why we had before the additional calculation in the height and the top position. I wonder if it was fixing some sizing thingy and I', afraid it can become regression for some devices.

Here is what I have found out

  • It seems that height was introduced with Fix scrolling behaviour on Nextcloud >= 14 907708f
  • The additional 3px (height) and the -3px (top) were added to Improve loading state handling c9cb1bd

@pedropintosilva
Copy link
Contributor

my conclusion: good to merge but we need to make sure if doesn't get backported to a version where it will brake other things

@juliushaertl juliushaertl merged commit ae3efae into main Dec 20, 2023
47 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/public-frame branch December 20, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants