Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drop use of deprecated jquery load #3469

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: Drop use of deprecated jquery load #3469

merged 1 commit into from
Feb 16, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Feb 13, 2024

Should make cypress pass again on main due to nextcloud/server#43469

We should get rid of all of that jquery stuff of course but this fixes the regression breaking some file opening scenarios and makes CI passing again.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Feb 13, 2024
Copy link

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@juliushaertl juliushaertl merged commit 20b035b into main Feb 16, 2024
44 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/cypress branch February 16, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants