Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/range requests #3505

Merged
merged 2 commits into from
Mar 5, 2024
Merged

feat/range requests #3505

merged 2 commits into from
Mar 5, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Feb 27, 2024

This PR implements rudimentary support for Range headers in the WOPI endpoint for downloading the file allowing the Collabora server to download the file in multiple chunks in parallel. During testing I've noticed that the webserver infront of Nextcloud might already cover general support but the full file would still be read, so this should bring a performance improvement by only reading relevant parts.

cc @mmeeks Since you were bringing this up for loading optimizations

Signed-off-by: Julius Härtl <jus@bitgrid.net>
…ontent

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@pedropintosilva
Copy link
Contributor

I think this was brought up by @mmeeks sometime ago (that we could try to split the document and downloaded its parts concurrently). @Ashod you are probably the right the person to look at this (to check if it brings a performance benefit when integrating with Collabora Online). What do you think?

Notes:

  • It doesn’t parse the Range header fully standard compatible, only one range is supported for now, however should be enough to proof that this brings a performance benefit when integrating with Collabora Online
  • There is already ongoing work to load the file earlier (at the request of the iframe, @Ashod was working on this, I think)

Copy link
Collaborator

@Ashod Ashod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juliushaertl. Good stuff!

@juliushaertl juliushaertl merged commit 1ef9f09 into main Mar 5, 2024
52 checks passed
@juliushaertl juliushaertl deleted the feat/range-requests branch March 5, 2024 14:29
@juliushaertl juliushaertl added the enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants