Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] match dark theme of system if no nextcloud theme specified #3551

Merged
merged 1 commit into from Mar 27, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 27, 2024

Backport of PR #3539

problem example:
a new user is created who uses system dark mode, so nextcloud will be in dark mode
but collabora would not be turned to dark mode as all the themes(ie:themeDark and themeDarkHighcontrast) value are undefined

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
@backportbot backportbot bot requested a review from juliushaertl March 27, 2024 07:58
@backportbot backportbot bot added bug Something isn't working 3. to review Ready to be reviewed labels Mar 27, 2024
@backportbot backportbot bot added this to the Nextcloud 27 milestone Mar 27, 2024
Copy link

cypress bot commented Mar 27, 2024

1 failed test on run #795 ↗︎

1 30 0 0 Flakiness 0

Details:

[stable27] match dark theme of system if no nextcloud theme specified
Project: Richdocuments Commit: 26ea100496
Status: Failed Duration: 02:36 💡
Started: Mar 27, 2024 8:03 AM Ended: Mar 27, 2024 8:06 AM
Failed  cypress/e2e/integration.spec.js • 1 failed test

View Output

Test Artifacts
Nextcloud integration > Save as Screenshots

Review all test suite changes for PR #3551 ↗︎

@juliushaertl juliushaertl merged commit ab6bbc1 into stable27 Mar 27, 2024
32 of 34 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/3539/stable27 branch March 27, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants