Support CRUD share permissions

Signed-off-by: Louis Chemineau <louis@chmn.me>

apps/files_sharing/lib/Controller/ShareAPIController.php

@@ -1004,10 +1004,9 @@ public function getInheritedShares(string $path): DataResponse {
 	}
 
 	/**
-	 * Check wether a permissions set contains some permissions.
-	 * @return bool
+	 * Check whether a set of permissions contains the permissions to check.
 	 */
-	private function hasPermission(int $permissionsSet, int $permissionsToCheck) {
+	private function hasPermission(int $permissionsSet, int $permissionsToCheck): bool {
 		return ($permissionsSet & $permissionsToCheck) === $permissionsToCheck;
 	}
 

apps/files_sharing/src/components/SharePermissionsEditor.vue

@@ -134,7 +134,7 @@ export default {
 
 	data() {
 		return {
-			randomFormName: Math.random().toString(27).substr(2),
+			randomFormName: Math.random().toString(27).substring(2),
 
 			showCustomPermissionsForm: false,
 
@@ -170,7 +170,7 @@ export default {
 		},
 
 		/**
-		 * Return wether the share's permission is a bundle.
+		 * Return whether the share's permission is a bundle.
 		 *
 		 * @return {boolean}
 		 */
@@ -182,7 +182,7 @@ export default {
 		},
 
 		/**
-		 * Return wether the share's permission is valid.
+		 * Return whether the share's permission is valid.
 		 *
 		 * @return {boolean}
 		 */
@@ -218,7 +218,7 @@ export default {
 
 	methods: {
 		/**
-		 * Return wether the share has the exact given permissions.
+		 * Return whether the share has the exact given permissions.
 		 *
 		 * @param {number} permissions - the permissions to check.
 		 *
@@ -230,7 +230,7 @@ export default {
 		},
 
 		/**
-		 * Return wether the share has the given permissions.
+		 * Return whether the share has the given permissions.
 		 *
 		 * @param {number} permissions - the permissions to check.
 		 *
@@ -253,7 +253,7 @@ export default {
 		},
 
 		/**
-		 * Return wether some given permissions can be toggled.
+		 * Return whether some given permissions can be toggled.
 		 *
 		 * @param {number} permissionsToToggle - the permissions to toggle.
 		 *

apps/files_sharing/src/lib/SharePermissionsToolBox.js

@@ -37,7 +37,7 @@ export const BUNDLED_PERMISSIONS = {
 }
 
 /**
- * Return wether a given permissions set contains some permissions.
+ * Return whether a given permissions set contains some permissions.
  *
  * @param {number} initialPermissionSet - the permissions set.
  * @param {number} permissionsToCheck - the permissions to check.
@@ -48,7 +48,7 @@ export function hasPermissions(initialPermissionSet, permissionsToCheck) {
 }
 
 /**
- * Return wether a given permissions set is valid.
+ * Return whether a given permissions set is valid.
  *
  * @param {number} permissionsSet - the permissions set.
  *
@@ -111,7 +111,7 @@ export function togglePermissions(initialPermissionSet, permissionsToToggle) {
 }
 
 /**
- * Return wether some given permissions can be toggled from a permission set.
+ * Return whether some given permissions can be toggled from a permission set.
  *
  * @param {number} permissionSet - the initial permissions set.
  * @param {number} permissionsToToggle - the permissions to toggle.