Skip to content

Commit

Permalink
fix(core): Do not invert app menu text color
Browse files Browse the repository at this point in the history
* Also fixes other cypress test
* Build assets

Signed-off-by: Philipp Hempel <Philipp.Hempel1@web.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
  • Loading branch information
susnux committed Jun 15, 2023
1 parent 645d9a9 commit 165d089
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion core/src/components/AppMenu.vue
Expand Up @@ -146,7 +146,6 @@ $header-icon-size: 20px;
height: 50px;
position: relative;
display: flex;
filter: var(--background-image-invert-if-bright);
&.app-menu-entry__active {
opacity: 1;
Expand Down Expand Up @@ -187,6 +186,7 @@ $header-icon-size: 20px;
height: $header-icon-size;
padding: calc((100% - $header-icon-size) / 2);
box-sizing: content-box;
filter: var(--background-image-invert-if-bright);
}
.app-menu-entry--label {
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/theming/admin-settings.cy.ts
Expand Up @@ -167,7 +167,7 @@ describe.only('Remove the default background with a bright color', function() {

it('See the header being inverted', function() {
cy.waitUntil(() => cy.window().then((win) => {
const firstEntry = win.document.querySelector('.app-menu-main li')
const firstEntry = win.document.querySelector('.app-menu-main li img')
if (!firstEntry) {
return false
}
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/theming/user-background.cy.ts
Expand Up @@ -162,7 +162,7 @@ describe('User select a bright custom color and remove background', function() {

it('See the header being inverted', function() {
cy.waitUntil(() => cy.window().then((win) => {
const firstEntry = win.document.querySelector('.app-menu-main li')
const firstEntry = win.document.querySelector('.app-menu-main li img')
if (!firstEntry) {
return false
}
Expand Down
4 changes: 2 additions & 2 deletions dist/core-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-main.js.map

Large diffs are not rendered by default.

0 comments on commit 165d089

Please sign in to comment.