fix(files): prevent dragging previews and appear as an external files…

… DnD Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud · Jan 18, 2024 · 1f8e372 · 1f8e372
1 parent 0b9e2fa
commit 1f8e372
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 13 deletions.
diff --git a/apps/files/src/components/DragAndDropNotice.vue b/apps/files/src/components/DragAndDropNotice.vue
@@ -115,8 +115,6 @@ export default defineComponent({
 			event.preventDefault()
 
 			const isForeignFile = event.dataTransfer?.types.includes('Files')
-
-			logger.debug('Drag over DragAndDropNotice', { isForeignFile, event })
 			if (isForeignFile) {
 				// Only handle uploading of outside files (not Nextcloud files)
 				this.dragover = true

diff --git a/apps/files/src/components/FileEntry.vue b/apps/files/src/components/FileEntry.vue
@@ -466,7 +466,10 @@ export default defineComponent({
 				return
 			}
 
-			logger.debug('Drag started')
+			logger.debug('Drag started', { event })
+
+			// Make sure that we're not dragging a file like the preview
+			event.dataTransfer?.clearData?.()
 
 			// Reset any renaming
 			this.renamingStore.$reset()

diff --git a/apps/files/src/components/FilesListVirtual.vue b/apps/files/src/components/FilesListVirtual.vue
@@ -266,7 +266,6 @@ export default defineComponent({
 		onDragOver(event: DragEvent) {
 			// Detect if we're only dragging existing files or not
 			const isForeignFile = event.dataTransfer?.types.includes('Files')
-
 			if (isForeignFile) {
 				// Only handle uploading of existing Nextcloud files
 				// See DragAndDropNotice for handling of foreign files

diff --git a/dist/614-614.js b/dist/614-614.js
diff --git a/dist/614-614.js.map b/dist/614-614.js.map
diff --git a/dist/core-unsupported-browser.js b/dist/core-unsupported-browser.js
diff --git a/dist/core-unsupported-browser.js.map b/dist/core-unsupported-browser.js.map
diff --git a/dist/files-main.js b/dist/files-main.js
diff --git a/dist/files-main.js.map b/dist/files-main.js.map