ILanguageModelTask: Use php type checking along with psalm parameteri…

…zed types Signed-off-by: Marcel Klehr <mklehr@gmx.net>
nextcloud · Jul 7, 2023 · 27e1c86 · 27e1c86
1 parent 0a94525
commit 27e1c86
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 12 deletions.
diff --git a/lib/public/LanguageModel/FreePromptTask.php b/lib/public/LanguageModel/FreePromptTask.php
@@ -39,15 +39,15 @@ final class FreePromptTask extends AbstractLanguageModelTask {
 	 * @inheritDoc
 	 * @since 28.0.0
 	 */
-	public function visitProvider($provider): string {
+	public function visitProvider(ILanguageModelProvider $provider): string {
 		return $provider->prompt($this->getInput());
 	}
 
 	/**
 	 * @inheritDoc
 	 * @since 28.0.0
 	 */
-	public function canUseProvider($provider): bool {
+	public function canUseProvider(ILanguageModelProvider $provider): bool {
 		return true;
 	}
 

diff --git a/lib/public/LanguageModel/HeadlineTask.php b/lib/public/LanguageModel/HeadlineTask.php
@@ -41,7 +41,7 @@ final class HeadlineTask extends AbstractLanguageModelTask {
 	 * @inheritDoc
 	 * @since 28.0.0
 	 */
-	public function visitProvider($provider): string {
+	public function visitProvider(ILanguageModelProvider $provider): string {
 		if (!$this->canUseProvider($provider)) {
 			throw new \RuntimeException('HeadlineTask#visitProvider expects IHeadlineProvider');
 		}
@@ -52,7 +52,7 @@ public function visitProvider($provider): string {
 	 * @inheritDoc
 	 * @since 28.0.0
 	 */
-	public function canUseProvider($provider): bool {
+	public function canUseProvider(ILanguageModelProvider $provider): bool {
 		return $provider instanceof IHeadlineProvider;
 	}
 

diff --git a/lib/public/LanguageModel/ILanguageModelTask.php b/lib/public/LanguageModel/ILanguageModelTask.php
@@ -62,18 +62,20 @@ interface ILanguageModelTask extends \JsonSerializable {
 	];
 
 	/**
-	 * @param T $provider
+	 * @psalm-param T $provider
+	 * @param ILanguageModelProvider $provider
 	 * @return string
 	 * @since 28.0.0
 	 */
-	public function visitProvider($provider): string;
+	public function visitProvider(ILanguageModelProvider $provider): string;
 
 	/**
-	 * @param T $provider
+	 * @psalm-param T $provider
+	 * @param ILanguageModelProvider $provider
 	 * @return bool
 	 * @since 28.0.0
 	 */
-	public function canUseProvider($provider): bool;
+	public function canUseProvider(ILanguageModelProvider $provider): bool;
 
 
 	/**

diff --git a/lib/public/LanguageModel/SummaryTask.php b/lib/public/LanguageModel/SummaryTask.php
@@ -41,7 +41,7 @@ final class SummaryTask extends AbstractLanguageModelTask {
 	 * @inheritDoc
 	 * @since 28.0.0
 	 */
-	public function visitProvider($provider): string {
+	public function visitProvider(ILanguageModelProvider $provider): string {
 		if (!$this->canUseProvider($provider)) {
 			throw new \RuntimeException('SummaryTask#visitProvider expects ISummaryProvider');
 		}
@@ -52,7 +52,7 @@ public function visitProvider($provider): string {
 	 * @inheritDoc
 	 * @since 28.0.0
 	 */
-	public function canUseProvider($provider): bool {
+	public function canUseProvider(ILanguageModelProvider $provider): bool {
 		return $provider instanceof ISummaryProvider;
 	}
 

diff --git a/lib/public/LanguageModel/TopicsTask.php b/lib/public/LanguageModel/TopicsTask.php
@@ -41,7 +41,7 @@ final class TopicsTask extends AbstractLanguageModelTask {
 	 * @inheritDoc
 	 * @since 28.0.0
 	 */
-	public function visitProvider($provider): string {
+	public function visitProvider(ILanguageModelProvider $provider): string {
 		if (!$this->canUseProvider($provider)) {
 			throw new \RuntimeException('TopicsTask#visitProvider expects ITopicsProvider');
 		}
@@ -52,7 +52,7 @@ public function visitProvider($provider): string {
 	 * @inheritDoc
 	 * @since 28.0.0
 	 */
-	public function canUseProvider($provider): bool {
+	public function canUseProvider(ILanguageModelProvider $provider): bool {
 		return $provider instanceof ITopicsProvider;
 	}