feat: replace id3parser with mp3info

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
nextcloud · Jun 28, 2023 · 3757f39 · 3757f39
1 parent fbc63fe
commit 3757f39
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/3rdparty b/3rdparty
diff --git a/lib/private/Preview/MP3.php b/lib/private/Preview/MP3.php
@@ -28,11 +28,10 @@
  */
 namespace OC\Preview;
 
-use ID3Parser\ID3Parser;
-
 use OCP\Files\File;
 use OCP\IImage;
 use Psr\Log\LoggerInterface;
+use wapmorgan\Mp3Info\Mp3Info;
 
 class MP3 extends ProviderV2 {
 	/**
@@ -46,11 +45,12 @@ public function getMimeType(): string {
 	 * {@inheritDoc}
 	 */
 	public function getThumbnail(File $file, int $maxX, int $maxY): ?IImage {
-		$getID3 = new ID3Parser();
-
 		$tmpPath = $this->getLocalFile($file);
+
 		try {
-			$tags = $getID3->analyze($tmpPath);
+			$audio = new Mp3Info($tmpPath, true);
+			/** @var string|null|false $picture */
+			$picture = $audio->getCover();
 		} catch (\Throwable $e) {
 			\OC::$server->get(LoggerInterface::class)->info($e->getMessage(), [
 				'exception' => $e,
@@ -61,12 +61,7 @@ public function getThumbnail(File $file, int $maxX, int $maxY): ?IImage {
 			$this->cleanTmpFiles();
 		}
 
-		$picture = isset($tags['id3v2']['APIC'][0]['data']) ? $tags['id3v2']['APIC'][0]['data'] : null;
-		if (is_null($picture) && isset($tags['id3v2']['PIC'][0]['data'])) {
-			$picture = $tags['id3v2']['PIC'][0]['data'];
-		}
-
-		if (!is_null($picture)) {
+		if (is_string($picture)) {
 			$image = new \OCP\Image();
 			$image->loadFromData($picture);