Merge pull request #26433 from nextcloud/limit-max-length-of-properties

Limit size of properties to 2048 characters
nextcloud · Apr 8, 2021 · 3ab659c · 3ab659c
2 parents 365569f + 2befac6
commit 3ab659c
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/lib/private/Accounts/AccountManager.php b/lib/private/Accounts/AccountManager.php
@@ -144,6 +144,17 @@ public function updateUser(IUser $user, array $data, bool $throwOnData = false):
 			}
 		}
 
+		// set a max length
+		foreach ($data as $propertyName => $propertyData) {
+			if (isset($data[$propertyName]) && isset($data[$propertyName]['value']) && strlen($data[$propertyName]['value']) > 2048) {
+				if ($throwOnData) {
+					throw new \InvalidArgumentException($propertyName);
+				} else {
+					$data[$propertyName]['value'] = '';
+				}
+			}
+		}
+
 		$allowedScopes = [
 			self::SCOPE_PRIVATE,
 			self::SCOPE_LOCAL,