fixup! fix(carddav): Check if SERVER variables are set before accessi…

…ng them
nextcloud · May 17, 2023 · 3f19956 · 3f19956
1 parent a65b0a8
commit 3f19956
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/apps/dav/lib/CardDAV/SystemAddressbook.php b/apps/dav/lib/CardDAV/SystemAddressbook.php
@@ -232,12 +232,13 @@ private function isFederation(): bool {
 		}
 
 		/** @psalm-suppress NoInterfaceProperties */
-		if (!isset($this->request->server['PHP_AUTH_USER']) || $this->request->server['PHP_AUTH_USER'] !== 'system') {
+		$server = $this->request->server;
+		if (!isset($server['PHP_AUTH_USER']) || $server['PHP_AUTH_USER'] !== 'system') {
 			return false;
 		}
 
 		/** @psalm-suppress NoInterfaceProperties */
-		$sharedSecret = $this->request->server['PHP_AUTH_PW'] ?? null;
+		$sharedSecret = $server['PHP_AUTH_PW'] ?? null;
 		if ($sharedSecret === null) {
 			return false;
 		}