Skip to content

Commit

Permalink
Theming: adjust background image resizing
Browse files Browse the repository at this point in the history
Support high resolution login images by resizing only images that are wider than 4096px

fixes #7459

Signed-off-by: Julius Härtl <jus@bitgrid.net>
  • Loading branch information
juliushaertl committed Jan 19, 2018
1 parent fdd7a53 commit 422e205
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions apps/theming/lib/Controller/ThemingController.php
Expand Up @@ -288,12 +288,10 @@ public function updateLogo() {
// Optimize the image since some people may upload images that will be
// either to big or are not progressive rendering.
$tmpFile = $this->tempManager->getTemporaryFile();
if (function_exists('imagescale')) {
// FIXME: Once PHP 5.5.0 is a requirement the above check can be removed
// Workaround for https://bugs.php.net/bug.php?id=65171
$newHeight = imagesy($image) / (imagesx($image) / 1920);
$image = imagescale($image, 1920, $newHeight);
}
$newWidth = imagesx($image) < 4096 ? imagesx($image) : 4096;
$newHeight = imagesy($image) / (imagesx($image) / $newWidth);
$image = imagescale($image, $newWidth, $newHeight);

imageinterlace($image, 1);
imagejpeg($image, $tmpFile, 75);
imagedestroy($image);
Expand Down

0 comments on commit 422e205

Please sign in to comment.