Skip to content

Commit

Permalink
Improve focus highlight
Browse files Browse the repository at this point in the history
The currently focused element (e.g. input field) is only hardly visible because the css files disable drawing of the outline.
This is really bad for usability especially when using keyboard navigation (with the TAB key).
  • Loading branch information
LiamHD committed Nov 15, 2016
1 parent 150b86a commit b540259
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
13 changes: 11 additions & 2 deletions core/css/inputs.css
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,13 @@ input[type="button"],
background-color: #fff;
color: #333;
border: 1px solid #ddd;
outline: none;
border-radius: 3px;
}

:focus {
outline: #0082c9 auto ;
}

input[type="hidden"] {
height: 0;
width: 0;
Expand Down Expand Up @@ -213,7 +217,6 @@ select {
-moz-appearance: none;
appearance: none;
background: url('../../core/img/actions/triangle-s.svg') no-repeat right 8px center rgba(240, 240, 240, 0.90);
outline: 0;
padding-right: 24px !important;
}

Expand Down Expand Up @@ -410,6 +413,12 @@ input[type="submit"] img, input[type="button"] img, button img, .button img { cu
box-shadow: none;
}

input[type="submit"]:focus, input[type="button"]:focus,
button:focus, .button:focus
{
color: #0082c9;
}

/* disabled input fields and buttons */
input:disabled, input:disabled:hover, input:disabled:focus,
button:disabled, button:disabled:hover, button:disabled:focus,
Expand Down
2 changes: 1 addition & 1 deletion core/css/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
This file is licensed under the Affero General Public License version 3 or later.
See the COPYING-README file. */

html, body, div, span, object, iframe, h1, h2, h3, h4, h5, h6, p, blockquote, pre, a, abbr, acronym, address, code, del, dfn, em, img, q, dl, dt, dd, ol, ul, li, fieldset, form, label, legend, table, caption, tbody, tfoot, thead, tr, th, td, article, aside, dialog, figure, footer, header, hgroup, nav, section { margin:0; padding:0; border:0; outline:0; font-weight:inherit; font-size:100%; font-family:inherit; vertical-align:baseline; cursor:default; }
html, body, div, span, object, iframe, h1, h2, h3, h4, h5, h6, p, blockquote, pre, a, abbr, acronym, address, code, del, dfn, em, img, q, dl, dt, dd, ol, ul, li, fieldset, form, label, legend, table, caption, tbody, tfoot, thead, tr, th, td, article, aside, dialog, figure, footer, header, hgroup, nav, section { margin:0; padding:0; border:0; font-weight:inherit; font-size:100%; font-family:inherit; vertical-align:baseline; cursor:default; }
html, body { height:100%; }
article, aside, dialog, figure, footer, header, hgroup, nav, section { display:block; }
body { line-height:1.5; }
Expand Down

0 comments on commit b540259

Please sign in to comment.