Skip to content

Commit

Permalink
LLM OCP API: Fix type errors
Browse files Browse the repository at this point in the history
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
  • Loading branch information
marcelklehr committed Jul 7, 2023
1 parent b8a9f08 commit b6a95e3
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 4 deletions.
15 changes: 15 additions & 0 deletions lib/public/LanguageModel/AbstractLanguageModelTask.php
Expand Up @@ -6,6 +6,7 @@

abstract class AbstractLanguageModelTask implements ILanguageModelTask {
protected ?int $id;
protected ?string $output;
protected int $status = ILanguageModelTask::STATUS_UNKNOWN;

final public function __construct(
Expand All @@ -26,6 +27,20 @@ abstract public function canUseProvider(ILanguageModelProvider $provider): bool;

abstract public function getType(): string;

/**
* @return string|null
*/
final public function getOutput(): ?string {
return $this->output;
}

/**
* @param string|null $output
*/
final public function setOutput(?string $output): void {
$this->output = $output;
}

/**
* @return int
*/
Expand Down
13 changes: 9 additions & 4 deletions lib/public/LanguageModel/ILanguageModelTask.php
Expand Up @@ -16,6 +16,11 @@ interface ILanguageModelTask extends \JsonSerializable {
TopicsTask::TYPE => TopicsTask::class,
];

public function visitProvider(ILanguageModelProvider $provider): string;

public function canUseProvider(ILanguageModelProvider $provider): bool;


/**
* @return string
*/
Expand Down Expand Up @@ -47,14 +52,14 @@ public function getId(): ?int;
public function getInput(): string;

/**
* @param string $output
* @param string|null $output
*/
public function setOutput(string $output): void;
public function setOutput(?string $output): void;

/**
* @return string
* @return null|string
*/
public function getOutput(): string;
public function getOutput(): ?string;

/**
* @return string
Expand Down

0 comments on commit b6a95e3

Please sign in to comment.