Skip to content

Commit

Permalink
add getDocBaseUrl that exted default
Browse files Browse the repository at this point in the history
Signed-off-by: Lorenzo Tanganelli <lorenzo.tanganelli@hotmail.it>
  • Loading branch information
tanganellilore committed Jun 19, 2023
1 parent b33cbec commit b83a752
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions apps/theming/lib/ThemingDefaults.php
Expand Up @@ -120,6 +120,7 @@ public function __construct(IConfig $config,
$this->iOSClientUrl = parent::getiOSClientUrl();
$this->AndroidClientUrl = parent::getAndroidClientUrl();
$this->FDroidClientUrl = parent::getFDroidClientUrl();
$this->docBaseUrl = parent::getDocBaseUrl();

Check failure on line 123 in apps/theming/lib/ThemingDefaults.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

UndefinedThisPropertyAssignment

apps/theming/lib/ThemingDefaults.php:123:3: UndefinedThisPropertyAssignment: Instance property OCA\Theming\ThemingDefaults::$docBaseUrl is not defined (see https://psalm.dev/040)

Check failure

Code scanning / Psalm

UndefinedThisPropertyAssignment Error

Instance property OCA\Theming\ThemingDefaults::$docBaseUrl is not defined
}

public function getName() {
Expand Down Expand Up @@ -163,6 +164,10 @@ public function getPrivacyUrl() {
return (string)$this->config->getAppValue('theming', 'privacyUrl', '');
}

public function getDocBaseUrl() {
return (string)$this->config->getAppValue('theming', 'docBaseUrl', $this->docBaseUrl);

Check failure on line 168 in apps/theming/lib/ThemingDefaults.php

View workflow job for this annotation

GitHub Actions / static-code-analysis

UndefinedThisPropertyFetch

apps/theming/lib/ThemingDefaults.php:168:70: UndefinedThisPropertyFetch: Instance property OCA\Theming\ThemingDefaults::$docBaseUrl is not defined (see https://psalm.dev/041)

Check failure

Code scanning / Psalm

UndefinedThisPropertyFetch Error

Instance property OCA\Theming\ThemingDefaults::$docBaseUrl is not defined

Check notice

Code scanning / Psalm

RedundantCastGivenDocblockType Note

Redundant cast to string given docblock-provided type
}

public function getShortFooter() {
$slogan = $this->getSlogan();
$baseUrl = $this->getBaseUrl();
Expand Down

0 comments on commit b83a752

Please sign in to comment.