Skip to content

Commit

Permalink
Merge pull request #43055 from nextcloud/backport/42999/stable28
Browse files Browse the repository at this point in the history
[stable28] fix(settings): Allow to connect to local address when checking for `.mjs` support
  • Loading branch information
blizzz committed Jan 23, 2024
2 parents ae1fa18 + 71e9036 commit bcea51d
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion apps/settings/lib/SetupChecks/JavaScriptModules.php
Expand Up @@ -64,12 +64,18 @@ public function run(): SetupResult {
foreach ($testURLs as $testURL) {
try {
$client = $this->clientService->newClient();
$response = $client->head($testURL, ['connect_timeout' => 10]);
$response = $client->head($testURL, [
'connect_timeout' => 10,
'nextcloud' => [
'allow_local_address' => true,
],
]);
if (preg_match('/(text|application)\/javascript/i', $response->getHeader('Content-Type'))) {
return SetupResult::success();
}
} catch (\Throwable $e) {
$this->logger->debug('Can not connect to local server for checking JavaScript modules support', ['exception' => $e, 'url' => $testURL]);
return SetupResult::warning($this->l10n->t('Could not check for JavaScript support. Please check manually if your webserver serves `.mjs` files using the JavaScript MIME type.'));
}
}
return SetupResult::error($this->l10n->t('Your webserver does not serve `.mjs` files using the JavaScript MIME type. This will break some apps by preventing browsers from executing the JavaScript files. You should configure your webserver to serve `.mjs` files with either the `text/javascript` or `application/javascript` MIME type.'));
Expand Down

0 comments on commit bcea51d

Please sign in to comment.