Skip to content

Commit

Permalink
Merge pull request #45262 from nextcloud/check-HttpsUrlGeneration
Browse files Browse the repository at this point in the history
fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
  • Loading branch information
come-nc committed May 13, 2024
2 parents 99f89bb + 5b5178a commit c31d6b1
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions apps/settings/lib/SetupChecks/HttpsUrlGeneration.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,19 @@ public function run(): SetupResult {
}
$generatedUrl = $this->urlGenerator->getAbsoluteURL('index.php');
if (!str_starts_with($generatedUrl, 'https://')) {
return SetupResult::warning(
$this->l10n->t('You are accessing your instance over a secure connection, however your instance is generating insecure URLs. This most likely means that you are behind a reverse proxy and the overwrite config variables are not set correctly.'),
$this->urlGenerator->linkToDocs('admin-reverse-proxy')
);
if (!\OC::$CLI) {
return SetupResult::warning(
$this->l10n->t('You are accessing your instance over a secure connection, however your instance is generating insecure URLs. This likely means that your instance is behind a reverse proxy and the Nextcloud `overwrite*` config values are not set correctly.'),
$this->urlGenerator->linkToDocs('admin-reverse-proxy')
);
/* We were called from CLI so we can't be 100% sure which scenario is applicable */
} else {
return SetupResult::info(
$this->l10n->t('Your instance is generating insecure URLs. If you access your instance over HTTPS, this likely means that your instance is behind a reverse proxy and the Nextcloud `overwrite*` config values are not set correctly.'),
$this->urlGenerator->linkToDocs('admin-reverse-proxy')
);
}
}

return SetupResult::success($this->l10n->t('You are accessing your instance over a secure connection, and your instance is generating secure URLs.'));
}
}

0 comments on commit c31d6b1

Please sign in to comment.