Skip to content

Commit

Permalink
Correct aria-label on action input and text field
Browse files Browse the repository at this point in the history
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
  • Loading branch information
JuliaKirschenheuter committed Sep 28, 2023
1 parent c5293bb commit c8fef9a
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 8 deletions.
1 change: 1 addition & 0 deletions apps/settings/src/components/GroupListItem.vue
Expand Up @@ -41,6 +41,7 @@
<NcActionInput v-if="id !== 'admin' && id !== 'disabled' && settings.isAdmin"
ref="displayNameInput"
icon="icon-edit"
:trailing-button-label="t('settings', 'Rename group')"
type="text"
:value="name"
:label=" t('settings', 'Rename group')"
Expand Down
7 changes: 5 additions & 2 deletions apps/settings/src/components/Users/UserRow.vue
Expand Up @@ -42,6 +42,7 @@
<NcTextField ref="displayNameField"
data-test="displayNameField"
class="user-row-text-field"
:trailing-button-label="t('settings', 'Change display name')"
:class="{ 'icon-loading-small': idState.loading.displayName }"
:show-trailing-button="true"
:disabled="idState.loading.displayName || isLoadingField"
Expand All @@ -68,11 +69,12 @@
<template v-if="idState.editing && settings.canChangePassword && user.backendCapabilities.setPassword">
<NcTextField class="user-row-text-field"
:class="{'icon-loading-small': idState.loading.password}"
:trailing-button-label="t('settings', 'Set new password')"
:show-trailing-button="true"
:disabled="idState.loading.password || isLoadingField"
:minlength="minPasswordLength"
maxlength="469"
:label="t('settings', 'Add new password')"
:label="t('settings', 'Set new password')"
trailing-button-icon="arrowRight"
:value.sync="idState.editedPassword"
autocapitalize="off"
Expand All @@ -93,8 +95,9 @@
<NcTextField class="user-row-text-field"
:class="{'icon-loading-small': idState.loading.mailAddress}"
:show-trailing-button="true"
:trailing-button-label="t('settings', 'Set new email address')"
:disabled="idState.loading.mailAddress || isLoadingField"
:label="t('settings', 'Add new email address')"
:label="t('settings', 'Set new email address')"
trailing-button-icon="arrowRight"
:value.sync="idState.editedMail"
autocapitalize="off"
Expand Down
4 changes: 2 additions & 2 deletions dist/settings-users-8351.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-users-8351.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/settings-vue-settings-apps-users-management.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-vue-settings-apps-users-management.js.map

Large diffs are not rendered by default.

0 comments on commit c8fef9a

Please sign in to comment.