fix: create only if file exists

Signed-off-by: Christopher Ng <chrng8@gmail.com>
nextcloud · Aug 3, 2023 · d31302e · d31302e
1 parent 777a791
commit d31302e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/apps/files_reminders/lib/Controller/ApiController.php b/apps/files_reminders/lib/Controller/ApiController.php
@@ -30,6 +30,7 @@
 use DateTimeInterface;
 use DateTimeZone;
 use Exception;
+use OCA\FilesReminders\Exception\NodeNotFoundException;
 use OCA\FilesReminders\Service\ReminderService;
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Http;
@@ -95,6 +96,8 @@ public function set(int $fileId, string $dueDate): JSONResponse {
 		try {
 			$this->reminderService->createOrUpdate($user, $fileId, $dueDate);
 			return new JSONResponse([], Http::STATUS_OK);
+		} catch (NodeNotFoundException $e) {
+			return new JSONResponse([], Http::STATUS_NOT_FOUND);
 		} catch (Throwable $th) {
 			$this->logger->error($th->getMessage(), ['exception' => $th]);
 			return new JSONResponse([], Http::STATUS_INTERNAL_SERVER_ERROR);

diff --git a/apps/files_reminders/lib/Service/ReminderService.php b/apps/files_reminders/lib/Service/ReminderService.php
@@ -31,6 +31,7 @@
 use OCA\FilesReminders\AppInfo\Application;
 use OCA\FilesReminders\Db\Reminder;
 use OCA\FilesReminders\Db\ReminderMapper;
+use OCA\FilesReminders\Exception\NodeNotFoundException;
 use OCA\FilesReminders\Exception\UserNotFoundException;
 use OCA\FilesReminders\Model\RichReminder;
 use OCP\AppFramework\Db\DoesNotExistException;
@@ -78,6 +79,9 @@ public function getAll(?IUser $user = null) {
 		);
 	}
 
+	/**
+	 * @throws NodeNotFoundException
+	 */
 	public function createOrUpdate(IUser $user, int $fileId, DateTime $dueDate): void {
 		$now = new DateTime('now', new DateTimeZone('UTC'));
 		try {
@@ -86,6 +90,10 @@ public function createOrUpdate(IUser $user, int $fileId, DateTime $dueDate): voi
 			$reminder->setUpdatedAt($now);
 			$this->reminderMapper->update($reminder);
 		} catch (DoesNotExistException $e) {
+			$nodes = $this->root->getUserFolder($user->getUID())->getById($fileId);
+			if (empty($nodes)) {
+				throw new NodeNotFoundException();
+			}
 			// Create new reminder if no reminder is found
 			$reminder = new Reminder();
 			$reminder->setUserId($user->getUID());