Merge pull request #37004 from nextcloud/backport/36803/stable24

[stable24] [db]: Remove not supported column comments for SQLite
nextcloud · Mar 14, 2023 · ea6b4c6 · ea6b4c6
2 parents 5af2aa1 + 2f0c60d
commit ea6b4c6
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/lib/private/DB/SQLiteMigrator.php b/lib/private/DB/SQLiteMigrator.php
@@ -40,9 +40,13 @@ protected function getDiff(Schema $targetSchema, \Doctrine\DBAL\Connection $conn
 		$platform->registerDoctrineTypeMapping('smallint unsigned', 'integer');
 		$platform->registerDoctrineTypeMapping('varchar ', 'string');
 
-		// with sqlite autoincrement columns is of type integer
 		foreach ($targetSchema->getTables() as $table) {
 			foreach ($table->getColumns() as $column) {
+				// column comments are not supported on SQLite
+				if ($column->getComment() !== null) {
+					$column->setComment(null);
+				}
+				// with sqlite autoincrement columns is of type integer
 				if ($column->getType() instanceof BigIntType && $column->getAutoincrement()) {
 					$column->setType(Type::getType('integer'));
 				}

diff --git a/tests/lib/DB/MigratorTest.php b/tests/lib/DB/MigratorTest.php
@@ -237,6 +237,30 @@ public function testReservedKeywords() {
 		$this->addToAssertionCount(1);
 	}
 
+	/**
+	 * Test for nextcloud/server#36803
+	 */
+	public function testColumnCommentsInUpdate() {
+		$startSchema = new Schema([], [], $this->getSchemaConfig());
+		$table = $startSchema->createTable($this->tableName);
+		$table->addColumn('id', 'integer', ['autoincrement' => true, 'comment' => 'foo']);
+		$table->setPrimaryKey(['id']);
+
+		$endSchema = new Schema([], [], $this->getSchemaConfig());
+		$table = $endSchema->createTable($this->tableName);
+		$table->addColumn('id', 'integer', ['autoincrement' => true, 'comment' => 'foo']);
+		// Assert adding comments on existing tables work (or at least does not throw)
+		$table->addColumn('time', 'integer', ['comment' => 'unix-timestamp', 'notnull' => false]);
+		$table->setPrimaryKey(['id']);
+
+		$migrator = $this->getMigrator();
+		$migrator->migrate($startSchema);
+
+		$migrator->migrate($endSchema);
+
+		$this->addToAssertionCount(1);
+	}
+
 	public function testAddingForeignKey() {
 		$startSchema = new Schema([], [], $this->getSchemaConfig());
 		$table = $startSchema->createTable($this->tableName);